rehash: streamline executables discovery; fix regression#3418
Merged
native-api merged 16 commits intopyenv:masterfrom Mar 7, 2026
Merged
rehash: streamline executables discovery; fix regression#3418native-api merged 16 commits intopyenv:masterfrom
native-api merged 16 commits intopyenv:masterfrom
Conversation
pyenv rehash; fix regressionThis reverts commit b95891a. Revert "[t] more debug info" This reverts commit 6aec4c1. Revert "[t] check sort version" This reverts commit ce9ce2b. Revert "[t] -irrelevant" This reverts commit b85335f. Revert "[t] print locale" This reverts commit 75f906c. Revert "[t] -irrelevant" This reverts commit efd7c67.
Member
Author
|
@jakelodwick I knew that corner cutting in the general case would bite us in the back at some point! |
Contributor
|
The readlink heuristic was too loose. I should have tested against pyenv-virtualenv's absolute symlinks. Thanks for the quick fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Prerequisite
Description
Fixes the regression by splitting the corner-cutting code for
rehashinto a dedicated branch.Further saves some time:
Tests
for the new switch