Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hashes for Python 3.14.0a5 tarballs #3196

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Update hashes for Python 3.14.0a5 tarballs #3196

merged 1 commit into from
Feb 13, 2025

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Feb 12, 2025

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

Tests

  • My PR adds the following unit tests (if any)

@jsirois
Copy link
Contributor Author

jsirois commented Feb 12, 2025 •
edited
Loading

C.F.: #3194

I had gotten:

:; pyenv install 3.14.0a5
Downloading Python-3.14.0a5.tar.xz...
-> https://www.python.org/ftp/python/3.14.0/Python-3.14.0a5.tar.xz

BUILD FAILED (Ubuntu 24.10 using python-build 2.5.2-7-ga7de2004)

Inspect or clean up the working tree at /tmp/python-build.20250212135734.10695
Results logged to /tmp/python-build.20250212135734.10695.log

Last 10 log lines:
/tmp/python-build.20250212135734.10695 ~/.pyenv

checksum mismatch: Python-3.14.0a5.tar.xz (file is corrupt)
expected e42d91d6dd3016bfc2f6f96c1129b40ca6d8f6e1bf3b30a11de146d930f43b32, got 74e83f26de1e4fb9eef1b56492cff92508834bb71ac13f5c580438ce9f093682

That prompted downloading the 2 tarballs and hashing them to get this fix. I tested the .tar.xz fix locally and it now installs.

@Mr0grog Mr0grog mentioned this pull request Feb 12, 2025
Merged
@jsirois
Copy link
Contributor Author

jsirois commented Feb 13, 2025 •
edited
Loading

Aha! The reason: https://discuss.python.org/t/python-3-14-0-alpha-5/80364/3

Python mutated their release. Not cool. This person spoke for me it seems: https://discuss.python.org/t/python-3-14-0-alpha-5/80364/6

@native-api
Copy link
Member

Python mutated their release. Not cool. This person spoke for me it seems: https://discuss.python.org/t/python-3-14-0-alpha-5/80364/6

Good thing I didn't make a release yet! 🙂

@native-api native-api merged commit 496dcfc into pyenv:master Feb 13, 2025
19 checks passed
@native-api native-api changed the title Fix hashes for Python 3.14.0a5 tarballs. Update hashes for Python 3.14.0a5 tarballs Feb 13, 2025
@hugovk
Copy link
Contributor

hugovk commented Feb 13, 2025

Aha! The reason: https://discuss.python.org/t/python-3-14-0-alpha-5/80364/3

Python mutated their release. Not cool. This person spoke for me it seems: https://discuss.python.org/t/python-3-14-0-alpha-5/80364/6

I apologise. It took three spins for this release so we decided it was okay for an alpha. Will be more careful next time, and this won't happen for beta and later releases.

@native-api
Copy link
Member

native-api commented Feb 13, 2025 •
edited
Loading

I thought whether to include this PR into release notes. Ultimately, reasoned that we ought to credit @jsirois for a critical fix so yes but chose a more neutral phrasing to avoid drawing unnecessary attention to the mistake.

@jsirois jsirois deleted the CPython/3.14.0a5/fix branch February 13, 2025 14:05
@jsirois
Copy link
Contributor Author

jsirois commented Feb 13, 2025

@hugovk thanks for chiming in. I'm not really concerned with your action per se, but it is disturbing that a >30 year old language has a release process that even permits mutation at all. I do understand though that Python is under-sourced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsirois @native-api @hugovk