Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenSSL version parsing in python-build script #3181

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

threadflow
Copy link
Contributor

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • This is a bug fix in the core functionality of version parsing, not suitable for a plugin implementation.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • This is a Python-specific OpenSSL version parsing fix, not applicable to rbenv.
  • My PR addresses the following pyenv issue (if any)
    • N/A - This is a standalone bug fix

Description

  • Here are some details about my PR:
    • Fixes OpenSSL version parsing in the openssl_version() function
    • The function was incorrectly parsing the first element of the version array instead of the second element after splitting on '-'
    • Changed ver[0] to ver[1] to correctly extract the version number portion
    • This ensures proper version comparison for OpenSSL builds

Tests

  • My PR adds the following unit tests:
    • No new tests added as this is a simple version parsing fix
    • The fix can be verified by building Python versions that depend on different OpenSSL versions

@native-api native-api merged commit 8d93cca into pyenv:master Feb 2, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants