Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust suggested shell startup code to support Pyenv with Pyenv-Win in WSL #3132

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

native-api
Copy link
Member

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

Subj.
There's a complaint that this results in duplicate PATH entries in nested shells, will deal with that separately

Tests

  • My PR adds the following unit tests (if any)
    N/A

…n WSL

There's a complaint that this results in duplicate PATH entries in nested shells, will deal with that separately
@native-api native-api merged commit 527d8fa into pyenv:master Dec 15, 2024
19 checks passed
@native-api native-api deleted the wsl_pyenv_win branch December 15, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyenv not being added to PATH in WSL if Pyenv-Win is on PATH
1 participant