Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PACKAGE_CPPFLAGS and PACKAGE_LDFLAGS #3130

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

native-api
Copy link
Member

@native-api native-api commented Dec 13, 2024

add test to test all the flag types

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR
    Allow to specify subj to complement existing PACKAGE_CFLAGS

Tests

  • My PR adds the following unit tests (if any)
    Test to test all the flags.
    Removed test that tested only some of the flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PACKAGE_LDFLAGS to python-build
1 participant