Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 for openssl-3.4.0 release in build 3.13.1 #3122

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

dlamblin
Copy link
Contributor

@dlamblin dlamblin commented Dec 6, 2024

The path before this change was wrong and resulted in the following message, provided here so others may search for the error message:

% pyenv install 3.13.1
Downloading openssl-3.4.0.tar.gz...
-> https://github.com/openssl/openssl/releases/download/openssl-3.3.2/openssl-3.4.0.tar.gz
error: failed to download openssl-3.4.0.tar.gz

BUILD FAILED (OS X 14.6.1 using python-build 2.4.21)

Results logged to /var/folders/yt/6fv7ccy95ql3cz6_8z00_hx80000gn/T/python-build.20241206115436.6774.log

Last 10 log lines:
via: 1.1 varnish
x-served-by: cache-ewr-kewr1740040-EWR
x-cache: HIT
x-cache-hits: 0
x-timer: S1733504077.891231,VS0,VE1
vary: Accept-Encoding
x-fastly-request-id: cb5cb260b1733a73c78f7fd58d09f1701d334a6a
content-length: 9379

curl: (56) The requested URL returned error: 404

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

The URL contains an old semver in the path for 3.2.2 where the file's semver is 3.4.0. This leads to a 404 from github.com. The patch corrects this to use the right path to openssl-3.4.0's release tar gz file.

Tests

I manually tested that the fix proceeds to get and build all parts of python 3.13.3 including openssl-3.4.0. If you're not using brew but just a plain macbook's macOS, you'll need this fix.

The path before this change was wrong and resulted in the following message, provided so others may search for the error message:
```
% pyenv install 3.13.1
Downloading openssl-3.4.0.tar.gz...
-> https://github.com/openssl/openssl/releases/download/openssl-3.3.2/openssl-3.4.0.tar.gz
error: failed to download openssl-3.4.0.tar.gz

BUILD FAILED (OS X 14.6.1 using python-build 2.4.21)

Results logged to /var/folders/yt/6fv7ccy95ql3cz6_8z00_hx80000gn/T/python-build.20241206115436.6774.log

Last 10 log lines:
via: 1.1 varnish
x-served-by: cache-ewr-kewr1740040-EWR
x-cache: HIT
x-cache-hits: 0
x-timer: S1733504077.891231,VS0,VE1
vary: Accept-Encoding
x-fastly-request-id: cb5cb260b1733a73c78f7fd58d09f1701d334a6a
content-length: 9379

curl: (56) The requested URL returned error: 404
```
@native-api
Copy link
Member

I'll complete #3123 first and retest this, to ensure this never happens again.

@native-api native-api merged commit 3bdb9bd into pyenv:master Dec 7, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.13.1 build has the wrong path to openssl-3.4.0 release tar
2 participants