Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer tcl-tk@8 from Homebrew due to release of Tcl/Tk 9 with which only 3.12+ are compatible #3118

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

native-api
Copy link
Member

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

Since 10.11.2024, Homebrew upgraded tck-tk to 9.0
which CPython is not compatible with yet

Tests

  • My PR adds the following unit tests (if any)
    N/A

native-api and others added 3 commits December 4, 2024 02:19
Since 10.11.2024, Homebrew upgraded tck-tk to 9.0
which CPython is not compatible with yet
@native-api native-api changed the title Prefer tcl-tk@8 from Homebrew Prefer tcl-tk@8 from Homebrew due to release of Tcl/Tk 9 with which only the newest CPython versions are compatible Dec 5, 2024
@native-api native-api changed the title Prefer tcl-tk@8 from Homebrew due to release of Tcl/Tk 9 with which only the newest CPython versions are compatible Prefer tcl-tk@8 from Homebrew due to release of Tcl/Tk 9 with which only 3.12+ are compatible Dec 5, 2024
@native-api native-api merged commit a39449b into pyenv:master Dec 5, 2024
17 checks passed
@native-api native-api deleted the prefer_tcltk_8 branch December 5, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tcl-tk from homebrew is now 9.0, not 8.6
1 participant