Skip to content

Add flags for Homebrew into python-config --ldflags#2384

Merged
native-api merged 4 commits intomasterfrom
python_config_homebrew
Jun 5, 2022
Merged

Add flags for Homebrew into python-config --ldflags#2384
native-api merged 4 commits intomasterfrom
python_config_homebrew

Conversation

@native-api
Copy link
Copy Markdown
Member

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

Python-config ignores build-time LDFLAGS and as such, doesn't print flags required for linking to Homebrew-provided libs. This causes an error when trying to embed Pyenv-provided Python that uses Homebrew-provided libs.

Tests

  • My PR adds the following unit tests (if any)

@native-api native-api merged commit bc13a87 into master Jun 5, 2022
@native-api native-api deleted the python_config_homebrew branch June 5, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"ld: library not found for -lintl" when linking against Pyenv-provided Python on an arm64 Mac

1 participant