Skip to content

Comments

Find zlib from xcode or brew on Mojave#1353

Merged
joshfriend merged 1 commit intopyenv:masterfrom
mikeroll:mojave-zlib
Jun 11, 2019
Merged

Find zlib from xcode or brew on Mojave#1353
joshfriend merged 1 commit intopyenv:masterfrom
mikeroll:mojave-zlib

Conversation

@mikeroll
Copy link
Contributor

@mikeroll mikeroll commented Jun 10, 2019 •
edited by joshfriend
Loading

An alternative take on #1219, based on the original attempt to fix that in #1339.

  • The zlib search flow is organized similarly to the readline one, and placed nearby.
  • The tests have been updated to account for the extra is_mac/uname call.

Fixes #1219
Closes #1339, #1333

@mikeroll mikeroll force-pushed the mojave-zlib branch 4 times, most recently from 99a5b5b to 3929ad7 Compare June 10, 2019 20:33
@mikeroll mikeroll mentioned this pull request Jun 10, 2019
Closed
@Croydon
Copy link

Croydon commented Jun 11, 2019

This would also replace #1333

@joshfriend
Copy link
Member

joshfriend commented Jun 11, 2019

Just checked this out and am getting clang compile commands like this:

clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -I. -I./Include -I/usr/local/opt/readline/include -I/usr/local/opt/readline/include -I/Users/josh/.pyenv/versions/3.7.3/include -I/usr/local/opt/icu4c/include -I/usr/local/opt/readline/include -I/usr/local/opt/readline/include -I/Users/josh/.pyenv/versions/3.7.3/include -I/usr/local/opt/icu4c/include -DPy_BUILD_CORE_BUILTIN -c ./Modules/hashtable.c -o Modules/hashtable.o

Which seems to correctly include the xcode sdk path from xcrun --show-sdk-path

@joshfriend joshfriend merged commit 4157973 into pyenv:master Jun 11, 2019
@joshfriend joshfriend mentioned this pull request Jun 11, 2019
Closed
5 tasks
Croydon added a commit to bincrafters/bincrafters-conventions that referenced this pull request Jul 3, 2019
@Croydon
Use XCode 10.2 and macOS 10.14 for Clang 10
e7149f2 
pyenv finally got the fix for macOS 10.14

pyenv/pyenv#1353

https://github.com/pyenv/pyenv/releases/tag/v1.2.12
@joshfriend joshfriend mentioned this pull request Dec 17, 2019
Closed
RakhithJK pushed a commit to RakhithJK/pyenv-pyenv-wiki that referenced this pull request Jun 1, 2024
@native-api
Additional headers no longer needed after pyenv/pyenv#1353 as per pye…
ba94465 
…nv/pyenv#1487 (comment)
native-api pushed a commit that referenced this pull request Sep 4, 2024
@audreee @mislav
Update code block in readme for rbenv-doctor script (#1353)
6cc7bff 
Co-authored-by: Mislav Marohnić <[email protected]>
@native-api native-api mentioned this pull request Dec 1, 2025
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Install failed, "zlib not available" on macOS Mojave

3 participants

@mikeroll @Croydon @joshfriend