Find zlib from Xcode or Homebrew on Mojave#1339
Closed
joshfriend wants to merge 1 commit intomasterfrom
Closed
Conversation
joshfriend
added
type: enhancement
os: macOS
area: build
joshfriend
force-pushed
the
fix-zlib-not-found-mojave
branch
from
88d239e to
ada0149
Compare
joshfriend
force-pushed
the
fix-zlib-not-found-mojave
branch
from
ada0149 to
b6a35d8
Compare
Member
Author
|
Lots of tests broke and i have no clue why |
Contributor
|
@joshfriend What can we do to help push this PR along? I am a new contributor to pyenv but would love to look into CI issues if you could provide some direction. |
Contributor
|
Please have a look at my variation (#1353) of the fix - with all the tests passing and the code reorganized a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this comment from #1219 pretty well summarizes why building pythons on Mojave keeps failing because of lack of zlib.
In this PR, I use the zlib from the xcode commandline tools sdk if available, and homebrew zlib if it is not. If neither are available, the build continues until the checks at the end that assert the presence of zlib and direct the user to the common build issues wiki if no zlib module was compiled. I didn't try to be clever about what happens if both scenarios above fail because the user might have done the manual legacy sdk installation fix or has
CFLAGSset in their shell or whatever.Fixes #1219