Skip to content

Comments

WIP: Test on macOS 10.14#1333

Closed
cclauss wants to merge 2 commits intopyenv:masterfrom
cclauss:patch-1
Closed

WIP: Test on macOS 10.14#1333
cclauss wants to merge 2 commits intopyenv:masterfrom
cclauss:patch-1

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 15, 2019

BUILD FAILED (OS X 10.14.3 using python-build 1.2.11-2-g23982d2)

Related to #1219 ??

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

Tests

  • My PR adds the following unit tests (if any)

@cclauss cclauss marked this pull request as ready for review April 15, 2019 14:37
@cclauss cclauss mentioned this pull request Apr 15, 2019
3 tasks
@joshfriend
Copy link
Member

superseded by #1353

@joshfriend joshfriend closed this Jun 11, 2019
@cclauss cclauss deleted the patch-1 branch June 11, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants