Repository navigation
Do not propose ligation of overhangs with ambiguous bases - #694
Open
barlowa124 wants to merge 1 commit into
Open
barlowa124 wants to merge 1 commit into
barlowa124 wants to merge 1 commit into
Conversation
sum_is_sticky compares overhangs as strings, so N matched N and the join was proposed even though the product cannot represent an N in a single-stranded region. The assembly then failed with TypeError at the internal join or at circular closure (pydna-group#691).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #691.
Overhang comparison in
sum_is_stickyis a plain string match, so twoends containing
Ncount as compatible and the join gets proposed. Productconstruction then fails with
TypeErrordownstream becausesingle-stranded regions reject ambiguous bases, at the internal
join or at circular closure.
Sticky ends that contain anything outside ACGT no longer count as
matching. Tests cover the match-level behavior and both reporter
assembly cases.
test_module_utils.pyandtest_module_assembly2.pypass.