Faster chunk checking for backend datasets #9808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
added
the
topic-chunked-arrays
dcherian
force-pushed
the
cache-chunking-backend-dataset
branch
from
8e80fb9 to
e2aad24
Compare
max-sixty
approved these changes
Nov 21, 2024
Collaborator
max-sixty
left a comment
max-sixty
left a comment
There was a problem hiding this comment.
I didn't re-think through the logic but the cache idea makes sense, thanks!
Contributor
Author
The core of it didn't change, just avoided materializing a huge iterable in memory in favor of finding the first disagreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rst