Skip to content

Use np.real and np.imag when possible #9368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Illviljan wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Use np.real and np.imag when possible #9368

Illviljan wants to merge 9 commits into from

Conversation

@Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Aug 15, 2024 •
edited
Loading

This reduces NamedArray's minimum requirements for a duckarray.

For example pd.Index doesn't have .real and .imag (or __array_function__/__array_namespace__ unfortunately, a problem for another PR...).

xref: #9314

@Illviljan Illviljan changed the title Namedarray np2 imag real Use np.real and np.imag when possible Aug 15, 2024
@Illviljan Illviljan added the topic-NamedArray Lightweight version of Variable label Aug 15, 2024
max-sixty
max-sixty reviewed Aug 15, 2024
View reviewed changes
@Illviljan Illviljan marked this pull request as ready for review August 15, 2024 21:05
@Illviljan
Copy link
Contributor Author

Illviljan commented Aug 15, 2024 

================================== FAILURES ===================================
________________________ xarray/tests/test_backends.py ________________________
[gw0] win32 -- Python 3.12.5 C:\Users\runneradmin\micromamba\envs\xarray-tests\python.exe
worker 'gw0' crashed while running 'xarray/tests/test_backends.py::TestNetCDF4ViaDaskData::test_roundtrip_coordinates'

flaky?

@TomNicholas
Copy link
Member

TomNicholas commented Aug 16, 2024

flaky?

Everything "dask roundtrip" seems to be somewhat flaky in my experience.

@max-sixty
Copy link
Collaborator

max-sixty commented Aug 16, 2024

(I would be +1 on xfailing anything like that, not as good as fixing but better than letting it break some reasonably high % of CI...)

@Illviljan Illviljan mentioned this pull request Aug 16, 2024
Merged
@Illviljan Illviljan mentioned this pull request Feb 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-sixty max-sixty max-sixty left review comments

Assignees

No one assigned

Labels

topic-NamedArray Lightweight version of Variable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Illviljan @TomNicholas @max-sixty