Skip to content

Conversation

@dcherian
Copy link
Contributor

Closes #9279
Closes #1460
Closes #2157

This was deprecated in January, so perhaps a bit soon.

OTOH this has been the source of some quite confusing behaviour (see linked issues above).

  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

@dcherian dcherian requested a review from max-sixty July 26, 2024 01:26
@dcherian dcherian force-pushed the delete-groupby-squeeze branch from be854f4 to b7351f9 Compare July 26, 2024 01:29
@dcherian dcherian force-pushed the delete-groupby-squeeze branch from b7351f9 to 71f46b4 Compare July 26, 2024 01:36
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

dcherian and others added 2 commits July 26, 2024 12:59
@dcherian dcherian added the plan to merge Final call for comments label Jul 26, 2024
@dcherian dcherian enabled auto-merge (squash) July 26, 2024 22:44
@dcherian dcherian merged commit 53c5634 into pydata:main Jul 26, 2024
Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, great to see this!


Deprecations
~~~~~~~~~~~~
- The ``squeeze`` kwarg to ``groupby`` is completely deprecated. This has been the source of some quite confusing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might phrase this as "no longer supported" rather than "completely deprecated".

@dcherian dcherian deleted the delete-groupby-squeeze branch July 27, 2024 12:18
aspitarl added a commit to MHDLab-Projects/MHD-Photoionization that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan to merge Final call for comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Different behavior of groupby with / without flox groupby should not squeeze out dimensions groupby should still squeeze for non-monotonic inputs

3 participants