Skip to content

Array API fixes for astype #7815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomNicholas wants to merge 156 commits into from
Closed

Array API fixes for astype #7815

TomNicholas wants to merge 156 commits into from

Conversation

@TomNicholas
Copy link
Member

@TomNicholas TomNicholas commented May 4, 2023

While it's common for duck arrays to have a .astype method, this doesn't exist in the new array API standard. We now have duck_array_ops.astype to deal with this, but for some reason changing it in just a couple more places broke practically every pint test in test_units.py 😕 @keewis

Builds on top of #7019 with just one extra commit to separate out this issue.

  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

TomNicholas and others added 30 commits September 10, 2022 17:44
@TomNicholas
generalise chunk methods to allow cubed
15fc2b8
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5e05b71 
for more information, see https://pre-commit.ci
@TomNicholas
fic typing typo
cff89ee
@TomNicholas
Merge branch 'cubed_integration' of https://github.com/TomNicholas/xa…
039973b 
…rray into cubed_integration
@TomNicholas
fixed circular import
60d44bc
@TomNicholas
fix some mypy errors
5ddba7e
@TomNicholas
added cubed to mypy ignore list
37d0d66
@TomNicholas
Merge branch 'main' into cubed_integration
67d7efc
@TomNicholas
simplify __array_ufunc__ check
cdcb3fb
@TomNicholas
Revert "simplify __array_ufunc__ check" as I pushed to wrong branch
73e4563 
This reverts commit cdcb3fb.
@TomNicholas
update cubed array type
5995685
@TomNicholas
Merge branch 'main' into cubed_integration
46223ae
@TomNicholas
fix missed conflict
320b09f
@TomNicholas
sketch for ChunkManager adapter class
3facfd6
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c616a85 
for more information, see https://pre-commit.ci
@TomNicholas @dcherian
Remove erroneous docstring about usage of map_blocks
ecabaa4 
Co-authored-by: Deepak Cherian <[email protected]>
@TomNicholas @dcherian
apply_ufunc -> apply_gufunc
e53a588 
Co-authored-by: Deepak Cherian <[email protected]>
@TomNicholas @dcherian
chunk -> from_array
fe21edd 
Co-authored-by: Deepak Cherian <[email protected]>
@TomNicholas
remove staticmethods
3f6aedc
@TomNicholas
attempt to type methods of ABC
ea8f482
@TomNicholas
from_array
c49ab8e
@TomNicholas
attempt to specify types
26d1868
@TomNicholas
method for checking array type
e9b4a33
@Illviljan
Merge branch 'main' into pr/7019
3a43b00
@Illviljan
Update pyproject.toml
c7c9589
@TomNicholas
Merge branch 'main' into cubed_integration
fc051e3
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
56e9d0f 
for more information, see https://pre-commit.ci
@TomNicholas
fixed import errors
3b16cca
@TomNicholas
generalize .chunk method kwargs
7ac3323
@TomNicholas
used dask functions in dask chunkmanager
e732b87
pre-commit-ci bot and others added 15 commits April 17, 2023 18:50
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
11676ab 
for more information, see https://pre-commit.ci
@TomNicholas
defined type for NormalizedChunks
76ce09e
@TomNicholas
Merge branch 'cubed_integration' of https://github.com/TomNicholas/xa…
127c184 
…rray into cubed_integration
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
604bbf3 
for more information, see https://pre-commit.ci
@TomNicholas
standardized capitalization of ChunkManagerEntrypoint
7604594
@TomNicholas
Merge branch 'cubed_integration' of https://github.com/TomNicholas/xa…
97537dd 
…rray into cubed_integration
@TomNicholas
Merge branch 'main' into cubed_integration
026fe17
@TomNicholas
ensure ruff doesn't remove import
355555f
@TomNicholas
ignore remaining typing errors stemming from unclear dask typing for …
6eac87a 
…chunks arguments
@TomNicholas
Merge branch 'main' into cubed_integration
f4224f6
@TomNicholas
rename store_kwargs->chunkmanager_store_kwargs
4ec8370
@TomNicholas
missed return value
316c63d
@TomNicholas
array API fixes for astype
9cd9078
@TomNicholas
Revert "array API fixes for astype"
5dc2016 
This reverts commit 9cd9078.
@TomNicholas
array API fixes for astype
a78326c
@TomNicholas TomNicholas added the topic-arrays related to flexible array support label May 4, 2023
@TomNicholas TomNicholas mentioned this pull request May 4, 2023
Merged
15 tasks
@TomNicholas
Copy link
Member Author

TomNicholas commented May 9, 2023

Just merged in #7820, which should hopefully fix this 🤞

@TomNicholas TomNicholas mentioned this pull request May 18, 2023
Merged
4 tasks
@TomNicholas
Copy link
Member Author

TomNicholas commented May 18, 2023

Closing in favour of #7847

@TomNicholas TomNicholas deleted the array_API_astype branch May 18, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

io topic-arrays related to flexible array support topic-backends topic-dask topic-indexing topic-rolling topic-typing topic-zarr Related to zarr storage library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomNicholas @Illviljan