Skip to content

Lint with ruff #7458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhamman merged 11 commits into from
Jan 30, 2023
Merged

Lint with ruff #7458

jhamman merged 11 commits into from
Jan 30, 2023

Conversation

@jhamman
Copy link
Member

@jhamman jhamman commented Jan 19, 2023 •
edited
Loading

This switches our primary linter to Ruff. As adervertised, Ruff is very fast. Plust we get the benefit of using a single tool that combines the previous functionality of pyflakes, isort, and pyupgrade.

cc @max-sixty, @TomNicholas

jhamman
jhamman commented Jan 19, 2023
View reviewed changes
jhamman
jhamman commented Jan 19, 2023
View reviewed changes
jhamman
jhamman commented Jan 19, 2023
View reviewed changes
@jhamman jhamman added Automation Github bots, testing workflows, release automation and removed topic-backends topic-indexing topic-CF conventions topic-arrays related to flexible array support io labels Jan 19, 2023
@jhamman
Copy link
Member Author

jhamman commented Jan 20, 2023

I plan to leave this as a WIP PR until #7461 is merged. There is a bit of overlap and dropping Python 3.8 will make this much easier to finish up.

@jhamman jhamman marked this pull request as ready for review January 26, 2023 18:14
dcherian
dcherian reviewed Jan 26, 2023
View reviewed changes
@jhamman jhamman merged commit 8437a55 into pydata:main Jan 30, 2023
@jhamman jhamman deleted the lint-with-ruff branch January 30, 2023 18:12
@jhamman jhamman mentioned this pull request Jan 30, 2023
Closed
@jrbourbeau jrbourbeau mentioned this pull request Jan 30, 2023
Closed
4 tasks
@etienneschalk etienneschalk mentioned this pull request Feb 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Illviljan Illviljan Illviljan left review comments

@dcherian dcherian dcherian approved these changes

+1 more reviewer

@charliermarsh charliermarsh charliermarsh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Automation Github bots, testing workflows, release automation CI Continuous Integration tools io topic-arrays related to flexible array support topic-backends topic-CF conventions topic-indexing topic-testing topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jhamman @charliermarsh @dcherian @Illviljan