Skip to content

Fix deepcopy of Variables and DataArrays #7089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomNicholas merged 9 commits into from
Sep 29, 2022
Merged

Fix deepcopy of Variables and DataArrays #7089

TomNicholas merged 9 commits into from
Sep 29, 2022

Conversation

@headtr1ck
Copy link
Collaborator

@headtr1ck headtr1ck commented Sep 26, 2022 •
edited
Loading

related to #2839

@keewis
Copy link
Collaborator

keewis commented Sep 26, 2022

I'd actually advise to xfail and merge the tests from #7086, and then undo the xfail here to verify that the fix actually works

@headtr1ck
Copy link
Collaborator Author

headtr1ck commented Sep 26, 2022

Ok, actually I have to revert the changes that would fix #6970...
It breaks stuff when people to da.attrs.update(some_dict)

@TomNicholas
Copy link
Member

TomNicholas commented Sep 28, 2022

Is this ready for review / merge @headtr1ck ?

@headtr1ck
Copy link
Collaborator Author

headtr1ck commented Sep 28, 2022 •
edited
Loading

Is this ready for review / merge @headtr1ck ?

We wanted to merge #7086 first.
Let's me see if I can get it done in the next hour or two.

@headtr1ck headtr1ck added the plan to merge Final call for comments label Sep 28, 2022
@TomNicholas TomNicholas enabled auto-merge (squash) September 29, 2022 15:44
@TomNicholas TomNicholas merged commit 2fe7875 into pydata:main Sep 29, 2022
@headtr1ck headtr1ck deleted the copyattrs branch September 29, 2022 20:46
@phockett phockett mentioned this pull request Sep 30, 2022
Open
This was referenced Sep 30, 2022
Closed
Closed
@aulemahal aulemahal mentioned this pull request Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomNicholas TomNicholas TomNicholas approved these changes

Assignees

No one assigned

Labels

plan to merge Final call for comments topic-indexing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dataset.copy(deep=True) does not deepcopy .attrs

3 participants

@headtr1ck @keewis @TomNicholas