Skip to content

Add dataarray scatter #6778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Illviljan merged 261 commits into from
Oct 7, 2022
Merged

Add dataarray scatter #6778

Illviljan merged 261 commits into from
Oct 7, 2022

Conversation

@Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Jul 12, 2022 •
edited
Loading

Splitting up #5622 as the scope of it has grown too large now.

  • Adds support for dataarray scatter plots and replaces the dataset version.
  • Scatter now has 3d support with the z argument.
  • Scatter now always returns a single pathcollection, earlier it could return a list of pathcollection when using categoricals
  • Better legend, handles now categoricals. Making continous/discrete options slightly redundant, still there though.
  • Facetgrid generalized slightly to handle 3d plots.

TODO:

  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

@Illviljan
allow adding any number of extra coords
e10d5ca
@Illviljan
Explain how ds will becom darray
474928f
@Illviljan
Update dataset_plot.py
54bd639
@Illviljan
Merge branch 'master' into Illviljan-dataset_line_plot
f58c52a
@Illviljan
Update dataset_plot.py
a8edc08
@Illviljan
use coords for coords
9c416f2
@Illviljan
Merge branch 'master' into Illviljan-dataset_line_plot
3ade6c4
@Illviljan
Merge branch 'master' into Illviljan-dataset_line_plot
c14ae47
@Illviljan
Merge branch 'master' into Illviljan-dataset_line_plot
93b50e2
@Illviljan
Explain goal of moving ds plots to da
7110220
@Illviljan
Merge branch 'master' into Illviljan-dataset_line_plot
76d42e5
@Illviljan
Merge branch 'main' into Illviljan-dataset_line_plot
b8c749d
@Illviljan
Merge branch 'main' into Illviljan-dataset_line_plot
3e90c1f
@Illviljan
Update dataset_plot.py
72c8e81
@Illviljan
Update dataset_plot.py
79dd87a
@Illviljan
Update dataset_plot.py
7b8fe1d
@Illviljan
handle non-existant coords
bf8b0ea
@Illviljan
Update dataset_plot.py
424a006
@Illviljan
Look through the kwargs to find extra coords
fe5bece
@Illviljan
output of legend labels has changed
8d5f5c6
@Illviljan
pop plt, comment out error test
a26992c
@Illviljan
Merge branch 'Illviljan-dataset_line_plot' into remove_dataset_scatter
61ba8db
@Illviljan
Update dataset_plot.py
f130b85
@Illviljan
Update facetgrid.py
89515ef
@Illviljan
move some funcs to utils
a7ee9f6
@Illviljan
add the funcs to the moved place
450c075
@Illviljan
Merge branch 'main' into remove_dataset_scatter
d70184a
@Illviljan
various bugfixes
5efcf12 
* use coords to check if valid
* only normalize sizes, hue is not necessary.
* Use same scatter parameter order as the dataset version.
* Fix tests assuming a list of patchollections is returned.
@Illviljan
improve ds to da wrapper
ac60266
@Illviljan
Filter kwargs
d33a8da
This was referenced Sep 16, 2022
Merged
Merged
@Illviljan Illviljan mentioned this pull request Sep 24, 2022
Merged
3 tasks
Illviljan and others added 12 commits September 25, 2022 17:36
@Illviljan
Merge branch 'main' into add_dataarray_scatter
6bd2354
@Illviljan
Merge branch 'main' into add_dataarray_scatter
699dd79
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7ba3da3 
for more information, see https://pre-commit.ci
@Illviljan
Merge branch 'main' into add_dataarray_scatter
d8d90b5
@Illviljan
Update facetgrid.py
f8aec60
@Illviljan
fix some mypy errors
c5f652f
@Illviljan
Merge branch 'main' into add_dataarray_scatter
566103b
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
dbc3368 
for more information, see https://pre-commit.ci
@Illviljan
Update plot.py
f76b5a3
@Illviljan
Merge branch 'add_dataarray_scatter' of https://github.com/Illviljan/…
96ad382 
…xarray into add_dataarray_scatter
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f5660e0 
for more information, see https://pre-commit.ci
@Illviljan
Update plot.py
34b1b98
@Illviljan Illviljan added the plan to merge Final call for comments label Oct 5, 2022
@Illviljan
Copy link
Contributor Author

Illviljan commented Oct 5, 2022

I'm merging this soon. Will hopefully go smoothly.

@headtr1ck
Copy link
Collaborator

headtr1ck commented Oct 6, 2022

I'm merging this soon. Will hopefully go smoothly.

I will wait with merging #7052
and then try to fix the merge conflicts :)

@Illviljan Illviljan merged commit 8dac64b into pydata:main Oct 7, 2022
@dcherian
Copy link
Contributor

dcherian commented Oct 7, 2022

Thanks @Illviljan !

@mathause
Copy link
Collaborator

mathause commented Oct 7, 2022

Nice work!

@benjeffery benjeffery mentioned this pull request Oct 17, 2022
Open
@Illviljan Illviljan mentioned this pull request Oct 17, 2022
Merged
@Illviljan Illviljan mentioned this pull request Jun 14, 2023
Closed
4 tasks
@Illviljan Illviljan mentioned this pull request Aug 6, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathause mathause mathause left review comments

Assignees

No one assigned

Labels

plan to merge Final call for comments topic-plotting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Illviljan @headtr1ck @dcherian @mathause @andersy005