pass kwargs through from save_mfdataset to to_netcdf #6686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds a `**kwargs` option to `xarray.save_mfdataset` that passes through to `to_netcdf`
andersy005
reviewed
Jun 10, 2022
|
|
||
|
|
||
| @pytest.mark.parametrize("test_type", ["baseline", "encoding_and_unlimited_dims"]) | ||
| def test_save_mfdataset_pass_kwargs(test_type): |
Member
There was a problem hiding this comment.
Could we move this test in the same test file as the rest of save_mfdataset tests?
xarray/xarray/tests/test_backends.py
Line 3672 in aa1d1d1
Contributor
Author
There was a problem hiding this comment.
sure thing. I'm not sure what the protocol for squashing commits is here: should I push a separate commit, or should I squash it with the original?
Member
There was a problem hiding this comment.
we squash commits when merging into main. So, i wouldn't worry about squashing commits in this PR.
Contributor
Author
There was a problem hiding this comment.
okay, got it, thanks!
* Move test_save_mfdataset_pass_kwargs to test_backends.py * Simplify the test
andersy005
reviewed
Jun 10, 2022
Contributor
Author
|
In looking at the failing tests, I see that a test associated with dask is failing. I didn't have dask installed in my local test environment, so I missed that. I've installed it and can now see the failed test locally too. I'm looking in to this now. |
Co-authored-by: Anderson Banihirwe <[email protected]>
Collaborator
|
Thanks @taobrienlbl ! |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Jun 12, 2022
* main: pass kwargs through from save_mfdataset to to_netcdf (pydata#6686) Docs: indexing.rst finetuning (pydata#6685) use micromamba instead of mamba (pydata#6674) install the development version of `matplotlib` into the upstream-dev CI (pydata#6675) Add whatsnew section for v2022.06.0 release notes for 2022.06.0rc0 release notes for the pre-release (pydata#6676) more testpypi workflow fixes (pydata#6673) thin: add examples (pydata#6663) Update multidimensional-coords.ipynb (pydata#6672) try to finally fix the TestPyPI workflow (pydata#6671) pin setuptools in the modify script (pydata#6669) fix the python version for the TestPyPI workflow (pydata#6668) upload wheels from `main` to TestPyPI (pydata#6660) Set keep_attrs for flox (pydata#6667)
|
thanks @taobrienlbl |
dcherian
added a commit
to bzah/xarray
that referenced
this pull request
Jun 24, 2022
* main: (129 commits) docs on specifying chunks in to_zarr encoding arg (pydata#6542) [skip-ci] List count under Aggregation (pydata#6711) Add `Dataset.dtypes` property (pydata#6706) try to import `UndefinedVariableError` from the new location (pydata#6701) DOC: note of how `chunks` can be defined (pydata#6696) pdyap version dependent client.open_url call (pydata#6656) use `pytest-reportlog` to generate upstream-dev CI failure reports (pydata#6699) [pre-commit.ci] pre-commit autoupdate (pydata#6694) Bump actions/setup-python from 3 to 4 (pydata#6692) Fix Dataset.where with drop=True and mixed dims (pydata#6690) pass kwargs through from save_mfdataset to to_netcdf (pydata#6686) Docs: indexing.rst finetuning (pydata#6685) use micromamba instead of mamba (pydata#6674) install the development version of `matplotlib` into the upstream-dev CI (pydata#6675) Add whatsnew section for v2022.06.0 release notes for 2022.06.0rc0 release notes for the pre-release (pydata#6676) more testpypi workflow fixes (pydata#6673) thin: add examples (pydata#6663) Update multidimensional-coords.ipynb (pydata#6672) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
**kwargsoption toxarray.save_mfdatasetthat passes through toto_netcdf, which allows theencodingandunlimited_dimsarguments to be passed through.**kwargsthrough fromsave_mfdatasettoto_netcdf#6684whats-new.rst