Skip to content

Conversation

@Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Feb 5, 2022

Make #6239 cleaner by running pyupgrade separately.

pyupgrade fixes typing only if from __future__ import annotations has been manually added to the file. Could probably do this in other files as well.

xref: #6244

@Illviljan
Copy link
Contributor Author

pre-commit.ci autofix

@Illviljan
Copy link
Contributor Author

Doc failure seems unrelated.

@Illviljan Illviljan added the plan to merge Final call for comments label Feb 5, 2022
@max-sixty
Copy link
Collaborator

pre-commit.ci autofix

I've seen this a couple of times. I thought I added it so it happened automatically. Does it not?

@max-sixty
Copy link
Collaborator

Thanks a lot @Illviljan !

(I don't think you need to wait for a review for these. Or lmk if you think we should and I will change my behavior :) )

@Illviljan
Copy link
Contributor Author

Thanks a lot @Illviljan !

(I don't think you need to wait for a review for these. Or lmk if you think we should and I will change my behavior :) )

Ok I'll merge. I was mostly waiting a little so a few could see the comments because I thought pyupgrade would just do the typing upgrade automagically, but it requires adding from __future__ import annotations manually for it to start editing.

@Illviljan Illviljan merged commit 56122ef into pydata:main Feb 5, 2022
@Illviljan
Copy link
Contributor Author

pre-commit.ci autofix

I've seen this a couple of times. I thought I added it so it happened automatically. Does it not?

I think this happens when pre-commit finds errors the 2nd time after it has already done a commit.

@Illviljan Illviljan deleted the pyupgrade_run branch August 12, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan to merge Final call for comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants