Skip to content

Replace dataset scatter with the dataarray version #5622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Illviljan wants to merge 174 commits into from
Closed

Replace dataset scatter with the dataarray version #5622

Illviljan wants to merge 174 commits into from

Conversation

@Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Jul 19, 2021 •
edited
Loading

  • Requires Add dataset line plot #4820
  • Tests added
  • Passes pre-commit run --all-files
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

@Illviljan
Add dataset line plot
3557771
@Illviljan
Update dataset_plot.py
fd822cd
@Illviljan
Update dataset_plot.py
516c0d0
@Illviljan
Handle when hue is not None
da30687
@Illviljan
sort and add linewidth
7127229 
linewidth and hue doesn't work together though, separate uses only.
@Illviljan
variant with dataarray
133ccd5
@Illviljan
Use the dataarray variant.
295352a
@Illviljan
Merge branch 'master' into Illviljan-dataset_line_plot
798d2b9
@Illviljan
copy doc from dataarray
4f1ddc2
@Illviljan
Update dataset_plot.py
ed31db7
@Illviljan
Update dataset_plot.py
fb7e9db
@Illviljan
allow adding any number of extra coords
e10d5ca
@Illviljan
Explain how ds will becom darray
474928f
@Illviljan
Update dataset_plot.py
54bd639
@Illviljan
Merge branch 'master' into Illviljan-dataset_line_plot
f58c52a
@Illviljan
Update dataset_plot.py
a8edc08
@Illviljan
use coords for coords
9c416f2
@Illviljan
Merge branch 'master' into Illviljan-dataset_line_plot
3ade6c4
@Illviljan
Merge branch 'master' into Illviljan-dataset_line_plot
c14ae47
@Illviljan
Merge branch 'master' into Illviljan-dataset_line_plot
93b50e2
@Illviljan
Explain goal of moving ds plots to da
7110220
@Illviljan
Merge branch 'master' into Illviljan-dataset_line_plot
76d42e5
@Illviljan
Merge branch 'main' into Illviljan-dataset_line_plot
b8c749d
@Illviljan
Merge branch 'main' into Illviljan-dataset_line_plot
3e90c1f
@Illviljan
Update dataset_plot.py
72c8e81
@pep8speaks

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
Illviljan and others added 16 commits March 6, 2022 22:01
@Illviljan
Merge branch 'main' into remove_dataset_scatter
8ed977c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
59212d4 
for more information, see https://pre-commit.ci
@Illviljan
Merge branch 'main' into remove_dataset_scatter
43a86a0
@Illviljan
Update utils.py
088bb87
@Illviljan
Merge branch 'main' into remove_dataset_scatter
1f87e66
@Illviljan
Merge branch 'main' into remove_dataset_scatter
69ee60a
@Illviljan
Merge branch 'main' into remove_dataset_scatter
9ab511d
@Illviljan
Update facetgrid.py
5d9d37d
@Illviljan
use add_labels inputs, explicit indexes now handles attrs
fa21c40
@Illviljan
colorbar in correct position
76b7e90
@Illviljan
Update plot.py
e164eee
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
77fefd8 
for more information, see https://pre-commit.ci
@Illviljan
Merge branch 'main' into remove_dataset_scatter
cb2c5ca
@Illviljan
Avoid always stacking
a09d933 
To avoid adding unnecessary NaNs.
@Illviljan
linecollection fixes
8ffc404 
TODO is to make sure the values are plotted the along the same axis.
@Illviljan
Merge branch 'main' into remove_dataset_scatter
91808f7
@Illviljan Illviljan mentioned this pull request Apr 28, 2022
Open
@Illviljan
Copy link
Contributor Author

Illviljan commented Jun 18, 2022

pre-commit.ci autofix

@Illviljan Illviljan mentioned this pull request Jul 12, 2022
Merged
3 tasks
@Illviljan Illviljan mentioned this pull request Sep 25, 2022
Merged
3 tasks
@Illviljan Illviljan mentioned this pull request Oct 16, 2022
Open
@Illviljan
Copy link
Contributor Author

Illviljan commented Aug 6, 2024

Done in #6778

@Illviljan Illviljan closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathause mathause mathause left review comments

Assignees

No one assigned

Labels

topic-plotting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Illviljan @pep8speaks @TomNicholas @mathause