Skip to content

Conversation

@raybellwaves
Copy link
Contributor

@pep8speaks
Copy link

pep8speaks commented Apr 15, 2021

Hello @raybellwaves! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-15 16:00:08 UTC

@max-sixty
Copy link
Collaborator

Great! Thanks as ever @raybellwaves

@max-sixty max-sixty merged commit 62d32ee into pydata:master Apr 16, 2021
@keewis
Copy link
Collaborator

keewis commented Apr 16, 2021

sorry for not answering sooner. The issue with the link is that we have multiple versions on RTD, so with a explicit link we're linking from a docstring in latest to stable. To fix that I think we should change that to

:doc:`io.zarr`

or something similar (I didn't check whether that label was defined) in a follow-up PR, with the disadvantage that this is not really useful when viewing with pydoc / help / IPython's ? operator.

@zmoon
Copy link
Contributor

zmoon commented Apr 16, 2021

Currently renders like this, which I don't think is intended.

image

numpydoc See Also section is really intended for references to code; it is taking http as the identifier (and linking to Python std lib's http package).

Edit: looks like there is an .. _io.zarr: anchor, so :ref:`io.zarr` should work? (or :doc:`io` for just the page)

@max-sixty
Copy link
Collaborator

Thanks @keewis & @zmoon , mea culpa.

@raybellwaves would you like to swap for @keewis 's suggestion? I'm happy to otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOC: link to_zarr docs to io section on zarr

5 participants