speedup attribute style access and tab completion #4742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
mathause
approved these changes
Jan 4, 2021
Collaborator
mathause
left a comment
mathause
left a comment
There was a problem hiding this comment.
LGTM (as far as I understand it)
max-sixty
reviewed
Jan 4, 2021
Collaborator
|
Looks great, thanks @rhkleijn |
dcherian
reviewed
Jan 4, 2021
Contributor
dcherian
left a comment
dcherian
left a comment
There was a problem hiding this comment.
using _coords and _coord_names should improve performance a little more
Collaborator
|
Thanks @rhkleijn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Attribute style access is slow #4741
Passes
isort . && black . && mypy . && flake8User visible changes (including notable bug fixes) are documented in
whats-new.rstmake _attr_sources and _item_sources lazy
make lookup of virtual dimension coordinates lazy
make helper class more general so it can be used for lookup of both virtual dimension and level coordinates