Skip to content

Conversation

@keewis
Copy link
Collaborator

@keewis keewis commented Sep 18, 2020

Now that #4409 is merged, we can add a CI that makes sure all examples actually work.

  • User visible changes (including notable bug fixes) are documented in whats-new.rst

Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition!

@keewis keewis merged commit 0af238c into pydata:master Sep 19, 2020
@keewis keewis deleted the doctest-CI branch September 19, 2020 10:38
@keewis
Copy link
Collaborator Author

keewis commented Sep 19, 2020

it seems the doctests are somehow failing after merging. Maybe due to #4419? If that's the case, it should be fine to just change the expected output.

@kmuehlbauer
Copy link
Contributor

@keewis Good chance, that #4419 already fixed some of the problems?

dcherian added a commit to dcherian/xarray that referenced this pull request Oct 9, 2020
…pagate-attrs

* 'propagate-attrs' of github.com:dcherian/xarray: (22 commits)
  silence sphinx warnings about broken rst (pydata#4448)
  Xarray open_mfdataset with engine Zarr (pydata#4187)
  Fix release notes formatting (pydata#4443)
  fix typo in io.rst (pydata#4250)
  Fix typo (pydata#4181)
  Fix release notes typo
  New whatsnew section
  Add notes re doctests (pydata#4440)
  Fixed dask.optimize on datasets (pydata#4438)
  Release notes for 0.16.1 (pydata#4435)
  Small updates to How-to-release + lint (pydata#4436)
  Fix doctests (pydata#4439)
  add a ci for doctests (pydata#4437)
  preserve original dimension, coordinate and variable order in ``concat`` (pydata#4419)
  Fix for h5py deepcopy issues (pydata#4426)
  Keep the original ordering of the coordinates (pydata#4409)
  Clearer Vectorized Indexing example (pydata#4433)
  Revert "Fix optimize for chunked DataArray (pydata#4432)" (pydata#4434)
  Fix optimize for chunked DataArray (pydata#4432)
  fix doc dataarray to netcdf (pydata#4424)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants