Silencing numpy warnings #4369
Merged
Silencing numpy warnings #4369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think this thread suggests to use |
max-sixty
commented
Aug 29, 2020
max-sixty
force-pushed
the
numpy-warning
branch
from
3b96fb1 to
055d834
Compare
keewis
reviewed
Aug 29, 2020
keewis
reviewed
Aug 29, 2020
keewis
reviewed
Aug 30, 2020
Co-authored-by: keewis <[email protected]>
max-sixty
commented
Aug 30, 2020
keewis
approved these changes
Sep 2, 2020
Collaborator
keewis
left a comment
keewis
left a comment
There was a problem hiding this comment.
LGTM, but the linter-enforced else clause seems a bit strange to me
Collaborator
Author
Yeah, I think it makes sense the context of the function alone — it doesn't know that the values are limited to the two parameterizations. Though this fix trades one error for another, in the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort . && black . && mypy . && flake8whats-new.rstIs this the right approach? Or should we be using
np.errstatemachinery?