Skip to content

Conversation

@max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Aug 22, 2020

No description provided.

Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks max.

@max-sixty max-sixty merged commit 34aa056 into pydata:master Aug 23, 2020
@max-sixty max-sixty deleted the pyupgrade branch August 23, 2020 21:10
variables.update({k: v for k, v in self._coords.items() if k != dim})
indexes = propagate_indexes(self._indexes, exclude=dim)
coord_names = set(self._coords) - set([dim])
coord_names = set(self._coords) - {dim}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be a problem if dim is a string?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on 3.8: image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants