Skip to content

Remove null pytest env option #4357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcherian merged 1 commit into from
Aug 31, 2020
Merged

Remove null pytest env option #4357

dcherian merged 1 commit into from
Aug 31, 2020

Conversation

@max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Aug 20, 2020

I don't think these lines do anything, and I see this warning on each run.

People wiser than me (@jhamman ) put it here — is there something it does do?

/usr/local/lib/python3.8/site-packages/_pytest/config/__init__.py:1148
  /usr/local/lib/python3.8/site-packages/_pytest/config/__init__.py:1148: PytestConfigWarning: Unknown config ini key: env

    self._warn_or_fail_if_strict("Unknown config ini key: {}\n".format(key))

-- Docs: https://docs.pytest.org/en/stable/warnings.html

@max-sixty max-sixty requested a review from jhamman August 30, 2020 18:02
@dcherian dcherian merged commit bea4d61 into pydata:master Aug 31, 2020
@max-sixty max-sixty deleted the pytest-env branch August 31, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhamman jhamman jhamman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@max-sixty @jhamman @dcherian