Skip to content

Fix swap_dims() index names (issue #3748) #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcherian merged 5 commits into from
Feb 24, 2020
Merged

Fix swap_dims() index names (issue #3748) #3752

dcherian merged 5 commits into from
Feb 24, 2020

Conversation

@jaicher
Copy link
Contributor

@jaicher jaicher commented Feb 4, 2020

@jaicher jaicher requested a review from dcherian February 4, 2020 20:26
@jaicher
Copy link
Contributor Author

jaicher commented Feb 4, 2020

I added a simple test, but not sure it is correctly set up. I wasn't sure about how pytest fixtures worked, so I didn't know if I needed/how to set up a new fixture to test the bugfix.

@jaicher
Copy link
Contributor Author

jaicher commented Feb 4, 2020

The 4 pytest failures per check are taking place in tests/test_plot.py. I suspect that these failures are unrelated to the pull request.

dcherian
dcherian reviewed Feb 5, 2020
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jaicher. I see that this is your first PR. Welcome!

This PR is looking great. I have two minor suggestions.

@jaicher jaicher requested a review from dcherian February 5, 2020 17:59
@jaicher
Added test for GH3748
b6a3c98
@jaicher
Rename newly created index in swap_dims() to dim name if not multiindex
38c2d21 
Fixes GH3748
@jaicher
Updated whats-new.rst with pull request information for swap_dims fix
bc15e3e
@jaicher
Move tests for GH3748 into existing swap_dims tests
f5b66f3 
+ integrated new tests for GH3748 for DataArray into existing swap_dims
  tests
+ added similar tests for Dataset
+ added test for multiindex case
@jaicher
Copy link
Contributor Author

jaicher commented Feb 6, 2020

We have different test failures than last time. They appear to be happening in tests with time indexes this time. I suspect these failures are again unrelated to the pull request.

dcherian
dcherian approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I'll merge once tests look good.

Thanks @jaicher

@dcherian
Copy link
Contributor

dcherian commented Feb 24, 2020

test failure is unrelated. Thanks @jaicher

@dcherian dcherian merged commit 18e34cc into pydata:master Feb 24, 2020
@max-sixty
Copy link
Collaborator

max-sixty commented Feb 24, 2020

Thanks a lot @jaicher

Thanks for all the recent reviews @dcherian ; I'll attempt to contribute a bit more...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcherian dcherian dcherian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

swap_dims() incorrectly changes underlying index name

3 participants

@jaicher @dcherian @max-sixty