plot: If provided with colormap do not modify it. #2935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
commented
May 2, 2019
| import numpy as np | ||
| import pandas as pd | ||
| import pytest | ||
| from numpy.testing import assert_array_equal |
Collaborator
|
Thanks for the PR, however this did not work for the minimal example @lvankampenhout provided because |
Contributor
Author
|
🤦♂️ Thanks @mathause. I was too sleepy I guess. The example now works; but the test doesn't work. It should fail for cmap='RdBu_r' but doesn't locally. Any suggestions would be helpful |
Contributor
Author
|
Never mind; should be all good now. |
* 'fix/2932' of github.com:dcherian/xarray: whats-new under bugfixes
why is this needed?
* 'fix/2932' of github.com:dcherian/xarray: @requires_matplotlib
* upstream/master: [WIP] Custom fill value for reindex, align, and merge operations (pydata#2920) Attempt to fix py35 build on Travis (pydata#2925) List formatting in docs (pydata#2939) DOC: Avoid downloading .tif file (pydata#2919)
Contributor
Author
|
Failed test is #2940. I'll merge in a few days if no one else has any comments |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Jun 21, 2019
This reverts commit ab39722.
Merged
shoyer
pushed a commit
that referenced
this pull request
Jun 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstfor all changes andapi.rstfor new APIIf provided a
Colormapwe don't override it anymore. facetgrid determines a colormap first and passes that down, so this prevents overwriting.