Various fixes for explicit Dataset.indexes #2858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GH2856 I've added internal consistency checks to the uses of ``assert_equal`` in our test suite, so this shouldn't happen again.
Member
Author
|
@pydata/xarray it would be great if someone could review this. I'd like to submit this and then issue the 0.12.1 bug fix release. |
Collaborator
|
I had a look through the code. I'm struggling a bit to be a good reviewer given my current understanding of how the goals connect to to the implementation. With that disclaimer, the code looks good. So if anyone knows this better, maybe have a look. |
Member
Author
Yes, this is the main part I was hoping for someone to take a look at. I would not trust my fixes if I did not believe the tests :). The rest of it are various smaller changes, mostly correcting my previously mistaken (and untested) implementations. |
Member
|
Thanks @shoyer and @max-sixty 👍. |
rabernat
pushed a commit
that referenced
this pull request
Apr 18, 2019
* added manual chunks for open_zarr * updated whats-new * fixed pep8 issues * removed whitespace * added deprecation warning * fixed pep8 issues * added warning for bad chunks * fixed lingering rebase conflicts * fixed pep8 issues * added stacklevel * fixed pep8 issues * Various fixes for explicit Dataset.indexes (#2858) * Various fixes for explicit Dataset.indexes Fixes GH2856 I've added internal consistency checks to the uses of ``assert_equal`` in our test suite, so this shouldn't happen again. * Fix indexes in Dataset.interp * 0.12.1 release * revert to 0.12.2 dev * update links to https (#2872) * Fix mypy typing error in cftime_offsets.py (#2878) * decreased pytest verbosity (#2881) * added manual chunks for open_zarr * updated whats-new * fixed pep8 issues * removed whitespace * added deprecation warning * fixed pep8 issues * added warning for bad chunks * fixed lingering rebase conflicts * fixed pep8 issues * added stacklevel * fixed pep8 issues * disallow unicode again * disallow unicode again
dcherian
added a commit
to yohai/xarray
that referenced
this pull request
Apr 19, 2019
* master: (29 commits) Handle the character array dim name (pydata#2896) Partial fix for pydata#2841 to improve formatting. (pydata#2906) docs: Move quick overview one level up (pydata#2890) Manually specify chunks in open_zarr (pydata#2530) Minor improvement of docstring for Dataset (pydata#2904) Fix minor typos in docstrings (pydata#2903) Added docs example for `xarray.Dataset.get()` (pydata#2894) Bugfix for docs build instructions (pydata#2897) Return correct count for scalar datetime64 arrays (pydata#2892) Indexing with an empty array (pydata#2883) BUG: Fix pydata#2864 by adding the missing vrt parameters (pydata#2865) Reduce length of cftime resample tests (pydata#2879) WIP: type annotations (pydata#2877) decreased pytest verbosity (pydata#2881) Fix mypy typing error in cftime_offsets.py (pydata#2878) update links to https (pydata#2872) revert to 0.12.2 dev 0.12.1 release Various fixes for explicit Dataset.indexes (pydata#2858) Fix minor typo in docstring (pydata#2860) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added internal consistency checks to the uses of
assert_equalin ourtest suite, so this shouldn't happen again.
whats-new.rstfor all changes andapi.rstfor new API