[WIP] added protect_dataset_variables_inplace to open_zarr #2813
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabernat
changed the title
3 tasks
Contributor
|
@rabernat Given the age of this, is this still in the works? |
Contributor
Author
|
Same answer as on #2814. Not quite sure whether there is interest in this feature. |
Contributor
|
Thanks @rabernat for the quick reply. I was skimming old issues/pr to see if there are some which might be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the same call to
_protect_dataset_variables_inplacetoopen_zarrwhich we find inopen_dataset. It wraps the arrays withindexing.MemoryCachedArray.As far as I can tell, it does not work, in the sense that nothing is cached.
whats-new.rstfor all changes andapi.rstfor new API