Make sure datetime object arrays are converted to datetime64 #2513
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dcherian
commented
Oct 26, 2018
dcherian
commented
- Closes to_netcdf() fails because of datetime encoding #2512 (remove if there is no corresponding issue, which should only be the case for minor changes)
- Tests added (for all bug fixes or enhancements)
|
Hello @dcherian! Thanks for submitting the PR.
|
Member
spencerkclark
left a comment
spencerkclark
left a comment
There was a problem hiding this comment.
Good catch! While you're at it, maybe for completeness you could add a test for converting an array of datetime.timedelta objects to np.timedelta64? Otherwise, pending a bug fix note addition to the what's new page, this looks good to me.
shoyer
reviewed
Oct 26, 2018
| 'without explicit dimension names. Pass a tuple of ' | ||
| '(dims, data) instead.' % (name, data.ndim)) | ||
| obj = Variable(name, obj, fastpath=True) | ||
| obj = Variable(name, data, fastpath=True) |
Member
There was a problem hiding this comment.
good catch! I love it when fixes are this simple :)
added 2 commits
October 26, 2018 05:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.