Check for minimum Zarr version. #1960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Mar 3, 2018
xarray/backends/zarr.py
Outdated
|
|
||
| if LooseVersion(zarr.__version__) < min_zarr: | ||
| raise NotImplementedError("Zarr version %s or greater is " | ||
| "required by xarray. See zarr " |
Contributor
There was a problem hiding this comment.
W291 trailing whitespace
shoyer
reviewed
Mar 5, 2018
Member
shoyer
left a comment
shoyer
left a comment
There was a problem hiding this comment.
One small suggestion, otherwise this looks great!
xarray/backends/zarr.py
Outdated
| import zarr | ||
| min_zarr = '2.2' | ||
|
|
||
| if LooseVersion(zarr.__version__) < min_zarr: |
Member
There was a problem hiding this comment.
Can you add # pragma: no cover to indicate that this clause shouldn't be included in coverage calculations?
Contributor
Author
There was a problem hiding this comment.
Sure thing, hope I did it right!
stickler-ci
reviewed
Mar 5, 2018
xarray/backends/zarr.py
Outdated
| import zarr | ||
| min_zarr = '2.2' | ||
|
|
||
| if LooseVersion(zarr.__version__) < min_zarr: # pragma: no cover |
Contributor
There was a problem hiding this comment.
E261 at least two spaces before inline comment
additional ws.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.