Use conda-forge netcdftime wherever netcdf4 was tested #1933
Conversation
|
Is it safe to do so? I.e. can it hide bugs in the current netCDF4 time handling? Also I think after #1920 it would be good to have a bit more info in the documentation about why people should switch to netcdftime or not. |
Save the one test failure here, I think this is going to be a fairly safe change. The
Agreed. Do you think I should include that here? |
As you wish! It can wait until the netcdftime documentation is up and running (most important I guess) |
|
@fmaussion - mind reviewing the updated documentation here? |
| geoscience specific file formats | ||
| - `zarr <http://zarr.readthedocs.io/>`__: for chunked, compressed, N-dimensional arrays. | ||
| - `netcdftime <https://github.com/Unidata/netcdftime>`__: recommended if you | ||
| - `netcdftime <https://unidata.github.io/netcdftime>`__: recommended if you |
There was a problem hiding this comment.
add: or dates before year 1678 or after year 2262
fmaussion
left a comment
fmaussion
left a comment
There was a problem hiding this comment.
Perfect, thanks! Now I'm excited to try it our on the CESM millennial ensemble files ;)
doc/time-series.rst
Outdated
| When decoding/encoding datetimes for non-standard calendars or for dates | ||
| before year 1678 or after year 2262, xarray uses the `netcdftime`_ library. | ||
| ``netcdftime`` was previously packaged with the ``netcdf4-python`` package but | ||
| is now diestributed separately. ``netcdftime`` is an |
|
@shoyer - do you think this is good to merge in its current state? |
|
My understanding is that netcdftime hasn't had an official release yet? Normally, you need to use some sort of prerelease channel and/or flag to download a package that hasn't had a normal release. |
|
right now, I don't andticipate any code changes before the final release. We're still working out the documentation site and whatnot.
|
|
Presumably netcdf4 will add a dependency on netcdftime so they don't break their API for users? Anyways, if this already work then yes I'm good with merging this. |
4 participants
Uh oh!
There was an error while loading. Please reload this page.