Add netcdftime as an optional dependency. #1920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 16, 2018 13:44
…n is not installed
shoyer
approved these changes
Feb 17, 2018
Member
Author
|
@spencerkclark, mind giving this a review? |
spencerkclark
approved these changes
Feb 18, 2018
Member
spencerkclark
left a comment
spencerkclark
left a comment
There was a problem hiding this comment.
@jhamman this looks good to me, thanks!
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstfor all changes andapi.rstfor new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)I've added a temporary travis build with the master branch of
netcdftime. After a while, we can probably remove that.This is helping us move towards Unidata/netcdf4-python#601 and #1252
cc @jswhit and @spencerkclark