Add dtype support for reduce methods. #1841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
reviewed
Jan 19, 2018
xarray/core/duck_array_ops.py
Outdated
| kwargs.pop('dtype', None) | ||
| kwargs.pop('out', None) | ||
| if kwargs.pop('out', None) is not None: | ||
| raise ValueError('`out` is not valid for {}'.format(name)) |
Member
There was a problem hiding this comment.
This should probably be TypeError for invalid argument names.
shoyer
reviewed
Jan 19, 2018
xarray/tests/test_dataarray.py
Outdated
| 'c': -999} | ||
| orig = DataArray([[-1, 0, 1], [-3, 0, 3]], coords, dims=['x', 'y']) | ||
|
|
||
| for dtype in [np.float32, np.float64, np.float128]: |
Member
There was a problem hiding this comment.
Looks like you'll need to remove np.float128. It appears that it's not available on Windows, which is triggering this test failure.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master **/*py | flake8 --diffwhats-new.rstfor all changes andapi.rstfor new APIFixes #1838.
The new rule for reduce is
as suggested in this comments.