Repository navigation
Fix error when passing skipna to Coarsen reduction methods in latest release - #11686
Merged
Merged
Conversation
2 of 3 tasks
headtr1ck
approved these changes
Oct 7, 2026
headtr1ck
approved these changes
Oct 7, 2026
1 task done
Co-authored-by: Michael Niklas <[email protected]>
emmanuelmathot
pushed a commit
to EOPF-Explorer/data-model
that referenced
this pull request
Oct 12, 2026
* chore(deps): group pending Dependabot updates Applies #272, #273, #284, #299, #300, #301 and #307 (except xarray, whose 2026.9.0 breaks coarsen(...).mean(skipna=True); see pydata/xarray#11686). Raises the urllib3, tornado and virtualenv security floors to the patched versions. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> * ci(dependabot): group major and security updates Major bumps, requirement widenings (zarr) and security updates each arrived as one PR per package; give them their own groups. Skip xarray 2026.9.0 until pydata/xarray#11686 ships. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> * chore(deps): bump multidict to 6.9.1 pip-audit blocks on CVE-2026-104874 in multidict 6.8.0, which fails the security job. Raise its floor with the other security constraints. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> --------- Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>
cursor Bot
pushed a commit
to Muddl/thymeandplace
that referenced
this pull request
Oct 13, 2026
xarray 2026.9.0 rejects skipna= on Coarsen reductions (pydata/xarray#11686, fix not released). mean() already skips NaNs by default, and the grid values match 2026.7.0 mean(skipna=True). Co-authored-by: Wade Kaiser <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The changes introduced #11556 resulted in reduction methods, when called on
Coarsenobjects, to error if the user specified the kwargskipna, which was previously supported. This was due to**kwargsbeing passed (incorrectly) to the_reduce_methodscall, when it should have only be passed to the underlying reduction method call. This PR also introduces tests aimed at preventing this regression in the future.cc @LOCEANlloydizard
Checklist
whats-new.rst