Repository navigation
ENH: Support DataTree in apply_ufunc - #11552
Merged
Merged
Conversation
shoyer
approved these changes
Sep 9, 2026
shoyer
left a comment
shoyer
left a comment
Member
There was a problem hiding this comment.
I'm sure there are some edge cases to figure out, but this looks good to me for now!
shoyer
enabled auto-merge (squash)
September 9, 2026 15:50
shoyer
disabled auto-merge
September 9, 2026 16:25
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
TomNicholas
added a commit
that referenced
this pull request
Sep 29, 2026
* Update whats-new for v2026.09.0 release - Rename the unreleased section to v2026.09.0 and add the release summary and contributor list - Move entries for #11348, #11292, #11290 and #11239 that were merged into older release sections - Add missing entries for #11552, #11521, #11486 and #11513 - Add missing PR links, fix the #11547 link and other markup - Fix the documented default of the use_bottleneck option - Add contributor names to the typos allow-list * Mention plot.lines and last Python 3.11 release in whats-new
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9789
Problem
apply_ufunccurrently treatsDataTreeas a dict-like object. Unary calls silently return only the rootDataset, while core-dimension and multi-tree calls can fail when child nodes reach the variable dispatch path.Solution
DataTreeinputs before the dict-likeDatasetpath.map_over_datasetsto apply the existingapply_ufuncmachinery at corresponding nodes, preserving tree structure, names, inherited coordinates, scalar arguments, kwargs, core dimensions, and tuple outputs.xarray.ufuncswrappers to operate over complete trees.Tests
python -m pytest -o addopts='' --basetemp D:/CodexCaches/pytest-xarray-9789-full xarray/tests/test_computation.py xarray/tests/test_ufuncs.py xarray/tests/test_datatree_mapping.py -q(323 passed, 131 skipped, 1 xfailed, 2 xpassed)ruff check xarray/computation/apply_ufunc.py xarray/ufuncs.py xarray/tests/test_computation.py xarray/tests/test_ufuncs.pyruff format --check xarray/computation/apply_ufunc.py xarray/ufuncs.py xarray/tests/test_computation.py xarray/tests/test_ufuncs.pygit diff --check