Repository navigation
Preserve coordinates after non-leading-dimension groupby reductions - #11290
Merged
dcherian merged 4 commits intoSep 28, 2026
Merged
Conversation
Use the reordered variable sizes when deciding which coordinates survive _replace_maybe_drop_dims, and add regression coverage for both the internal helper and groupby behavior.
7 tasks done
dcherian
reviewed
Sep 28, 2026
Co-authored-by: Michael Niklas <[email protected]>
dcherian
enabled auto-merge (squash)
September 28, 2026 13:40
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
TomNicholas
added a commit
that referenced
this pull request
Sep 29, 2026
* Update whats-new for v2026.09.0 release - Rename the unreleased section to v2026.09.0 and add the release summary and contributor list - Move entries for #11348, #11292, #11290 and #11239 that were merged into older release sections - Add missing entries for #11552, #11521, #11486 and #11513 - Add missing PR links, fix the #11547 link and other markup - Fix the documented default of the use_bottleneck option - Add contributor names to the typos allow-list * Mention plot.lines and last Python 3.11 release in whats-new
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fallback
groupbyreductions can reorder variable dimensions beforeDataArray._replace_maybe_drop_dimsfilters coordinates. That path still zipped shapes against the original dimension order, which dropped unrelated coordinates when the reordered dimensions had different lengths.This switches that branch to use
variable.sizesand adds regression coverage for both the helper and the user-visiblegroupbybehavior.Checklist
whats-new.rstapi.rst(N/A - no new public API)AI Disclosure
Tools: Codex