Skip to content

Conversation

@kmnhan
Copy link
Contributor

@kmnhan kmnhan commented Apr 28, 2025

Hi! I am the author of xarray-lmfit and would like to propose adding it to the ecosystem documentation. This package extends xarray with curve fitting capabilities using the lmfit library. Please let me know if there are any changes needed. Thank you for your consideration!

@welcome
Copy link

welcome bot commented Apr 28, 2025

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.

@kmnhan kmnhan marked this pull request as ready for review April 28, 2025 08:19
@dcherian
Copy link
Contributor

This is great, we could add it to the See Also section of the docstrings for curvefit and polyfit if you'd like.

@kmnhan
Copy link
Contributor Author

kmnhan commented Apr 29, 2025

Thanks for the suggestion! I think adding it to the docstring could help users discover it, but I’m a bit concerned it might be confusing since it’s an external package with a different API. Would it make sense to clarify this in the docstring, or would you prefer to keep the reference in the ecosystem docs only? Happy to go with whatever you think is best.

@dcherian
Copy link
Contributor

Yeah you can add a line saying "external module with more curve fitting functionality"

@dcherian dcherian merged commit 070af11 into pydata:main May 1, 2025
32 checks passed
@welcome
Copy link

welcome bot commented May 1, 2025

Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! celebration gif

@kmnhan kmnhan deleted the docs-xarray-lmfit branch May 1, 2025 05:31
dcherian added a commit to dcherian/xarray that referenced this pull request May 7, 2025
* main:
  dev whats-new (pydata#10294)
  Add SeasonGrouper, SeasonResampler (pydata#9524)
  (fix): remove `PandasExtensionArray` from repr (pydata#10291)
  Do not rely on `np.broadcast_to` to perform trivial dimension insertion (pydata#10277)
  DOC: Remove reference to absolufy (pydata#10290)
  Fix for scalar detection (pydata#8821)
  Add Index.validate_dataarray_coord (pydata#10137)
  add redirect for contributing guide (pydata#10282)
  Update pre-commit hooks (pydata#10288)
  Adding xarray-eopf to ecosystem.rst (pydata#10289)
  Add public typing.py module (pydata#10215)
  Rename Twitter to X (pydata#10283)
  Add `xarray-lmfit` extension for curve fitting to ecosystem documentation (pydata#10262)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants