Skip to content

Forbid datatree to zarr append dim #10156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomNicholas merged 16 commits into from
Mar 20, 2025
Merged

Forbid datatree to zarr append dim #10156

TomNicholas merged 16 commits into from
Mar 20, 2025

Conversation

@TomNicholas
Copy link
Member

@TomNicholas TomNicholas commented Mar 20, 2025 •
edited
Loading

Adding this didn't break a single test, meaning that we are not currently testing DataTree.to_zarr(append_dim=...) at all. This is meant as a stopgap to avoid undefined behaviour until #9858 is resolved

  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

TomNicholas and others added 15 commits October 24, 2024 17:48
@TomNicholas
new blank whatsnew
01e7518
@TomNicholas
Merge branch 'main' of https://github.com/pydata/xarray
83e553b
@TomNicholas
Merge branch 'main' of https://github.com/pydata/xarray
e44326d
@TomNicholas
Merge branch 'main' of https://github.com/pydata/xarray
4e4eeb0
@TomNicholas
Merge branch 'main' of https://github.com/pydata/xarray
d858059
@TomNicholas
Merge branch 'main' of https://github.com/pydata/xarray
d377780
@TomNicholas
Merge branch 'main' of https://github.com/pydata/xarray
3132f6a
@TomNicholas
Merge branch 'main' of https://github.com/pydata/xarray
900eef5
@TomNicholas
Merge branch 'main' of https://github.com/pydata/xarray
4c4462f
@TomNicholas
Merge branch 'main' of https://github.com/pydata/xarray
5b9b749
@TomNicholas
Merge branch 'main' of https://github.com/pydata/xarray
fadb953
@TomNicholas
Merge branch 'main' of https://github.com/TomNicholas/xarray
57d9d23
@TomNicholas
Merge branch 'main' of https://github.com/pydata/xarray
11170fc
@TomNicholas
Merge branch 'main' of https://github.com/pydata/xarray
0b8fa41
@TomNicholas
forbid trying to append a DataTree to an existing zarr store
81b0df4
@TomNicholas TomNicholas added topic-zarr Related to zarr storage library topic-DataTree Related to the implementation of a DataTree class labels Mar 20, 2025
@TomNicholas TomNicholas added the plan to merge Final call for comments label Mar 20, 2025
@TomNicholas TomNicholas mentioned this pull request Mar 20, 2025
Open
5 tasks
dcherian
dcherian approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call.

@TomNicholas TomNicholas merged commit b7c1c11 into pydata:main Mar 20, 2025
37 checks passed
@TomNicholas TomNicholas deleted the forbid_datatree_to_zarr_append_dim branch March 20, 2025 14:55
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 25, 2025
@dcherian
Merge remote-tracking branch 'upstream/main' into custom-groupers
e3413f3 
* upstream/main:
  Move chunks-related functions to a new file (pydata#10172)
  Preserve label ordering for multi-variable GroupBy (pydata#10151)
  Update DataArray.to_zarr to match Dataset.to_zarr. (pydata#10164)
  Fix numpy advanced indexing docs link (pydata#10160)
  Forbid datatree to zarr append dim (pydata#10156)
  Fix GitHub Actions badge in README (pydata#10155)
  Add dev whats-new (pydata#10152)
  Release 2025.03.0 (pydata#10143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcherian dcherian dcherian approved these changes

Assignees

No one assigned

Labels

plan to merge Final call for comments topic-DataTree Related to the implementation of a DataTree class topic-zarr Related to zarr storage library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomNicholas @dcherian