-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
Description
What is your issue?
Now that we've bumped our minimum NumPy version to 1.21, we can address this comment:
Lines 57 to 62 in b21f62e
| # once NumPy 1.21 is minimum version, use NumPys definition directly | |
| # 1.20 uses a non-generic Protocol (like we define here for simplicity) | |
| class _SupportsDType(Protocol): | |
| @property | |
| def dtype(self) -> np.dtype: | |
| ... |
I decided not to tackle this as part of #7461 but we may be able to do something like this:
from numpy.typing._dtype_like import _DTypeLikeNested, _ShapeLike, _SupportsDTypexref: #6834
cc @headtr1ck
Illviljan and headtr1ck