Skip to content

Conversation

@larsoner
Copy link
Contributor

@larsoner larsoner commented Jun 5, 2024

It seems like it should be okay to run packaging steps on each PR and push to main, but we'll see if it adds a lot of overhead. Then also add a nightly wheel upload to https://anaconda.org/scientific-python-nightly-wheels.

This will require getting an Anaconda token from the appropriate folks and adding it as a secret, so marking as a draft for now.

@larsoner
Copy link
Contributor Author

larsoner commented Jun 5, 2024

Argh it creates a second set of duplicate tests so that's no good. So we should remove the pull_request: before merging, too. I'll leave it in for now just so that we can see things green first.

@larsoner
Copy link
Contributor Author

larsoner commented Jun 5, 2024

Okay this looks pretty reasonable, I think it maybe would have worked:

https://github.com/pydata/pydata-sphinx-theme/actions/runs/9389922668/job/25859082226

I'll disable the PR build part and then work on the token!

Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to go right @larsoner ?

@trallard or @Carreau I'll let you merge

@larsoner
Copy link
Contributor Author

larsoner commented Jun 6, 2024

Yep that's right

@trallard
Copy link
Collaborator

trallard commented Jun 6, 2024

This looks good, so will go ahead and merge 🚀

@trallard trallard added kind: maintenance Improving maintainability and reducing technical debt tag: CI Pull requests that update GitHub Actions code labels Jun 6, 2024
@trallard trallard merged commit a019f22 into pydata:main Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: maintenance Improving maintainability and reducing technical debt tag: CI Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants