Fix CLI parsing error for set field types since 2.13.0 (#787)#788
Merged
Fix CLI parsing error for set field types since 2.13.0 (#787)#788
Conversation
hramezani
force-pushed
the
fix/cli-set-type-subscript-error
branch
from
546b2a4 to
71c6892
Compare
The numeric type coercion added in #769 used `[0]` to index the result of `validate_python`, which fails for `set` types since sets are not subscriptable. Use `next(iter(...))` instead which works for any iterable. Co-Authored-By: Claude Opus 4.6 <[email protected]>
hramezani
force-pushed
the
fix/cli-set-type-subscript-error
branch
from
71c6892 to
7475ae5
Compare
hramezani
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #787
Summary
SettingsError: 'set' object is not subscriptablewhen usingset[str]orset[int]fields withcli_parse_args=True[0]to index the result ofvalidate_python, which fails forsettypes since sets are not subscriptablenext(iter(...))instead which works for any iterable (lists, sets, frozensets, etc.)Test plan
test_cli_set_argcoveringset[str]andset[int]CLI argument parsingmake formatclean🤖 Generated with Claude Code