Fix RecursionError with self-referential models in CliApp#783
Merged
Fix RecursionError with self-referential models in CliApp#783
Conversation
b386dac to
c2c660a
Compare
kschwab
reviewed
Feb 17, 2026
Co-Authored-By: Claude Opus 4.6 <[email protected]>
9c62414 to
329c799
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CliApp.run()with a model containing a self-referential field (e.g.,foo: Optional["Foo"]), the CLI argument parser entered infinite recursion between_add_parser_argsand_add_parser_submodelsmodel_pathparameter that tracks ancestor models in the current recursion chain. Before expanding a submodel into CLI flags, it checks whether the model is already being processed — if so, it skips the expansion to break the cycle--foo '{"foo": {"foo": null}}'), only the infinite CLI flag expansion is preventedTest plan
test_cli_self_referential_modelcovering nested JSON values for self-referential models🤖 Generated with Claude Code