Repository navigation
fix(codes): accept any letter case and surrounding whitespace in ISO … - #454
Merged
yezz123 merged 1 commit intoOct 19, 2026
Merged
Conversation
…15924 script codes
yezz123
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…15924 script codesFollow-up to #451.
ISO_15924only accepted the exact form"Latn":"latn"and"LATN"were rejected as invalid codes, and" Latn "failed with "String should have at most 4 characters". The country, currency and language code types accept any letter case and, since #451, surrounding whitespace.ISO_15924now strips surrounding whitespace in its string schema and normalises the case to the canonical form (initial capital, as every code in pycountry is written), so all of these give"Latn". Whitespace inside a code is still rejected. Added cases totests/test_scripts.py.