Repository navigation
fix(codes): allow whitespace around currency, country and language codes - #451
Merged
yezz123 merged 1 commit intoOct 18, 2026
Merged
Conversation
yezz123
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The currency, country and language code types already accept any letter case (
"usd"gives"USD","in"gives"IN"), but a value with surrounding whitespace, such as" USD "or"India\n", was rejected. For currencies the message was even misleading: "String should have at most 3 characters".PaymentCardNumberandABARoutingNumberalready strip whitespace through their string schema.The string schemas of
ISO4217,Currency,CountryAlpha2,CountryAlpha3,CountryNumericCode,CountryShortName,LanguageAlpha2,LanguageName,ISO639_3andISO639_5now setstrip_whitespace=True, the same way. Whitespace inside a code is still rejected, and whitespace-only input is still invalid (the existingprintablecases cover it). Added whitespace cases to the currency tests and a test for each country and language type.