Repository navigation
fix(isbn): accept hyphens and spaces between the parts of an ISBN - #440
Merged
Merged
Conversation
yezz123
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISBNs are almost always written with hyphens or spaces between their parts, as on a book's back cover (
978-3-16-148410-0,0-306-40615-2), and ISO 2108 allows either.ISBNrejected these with "Length for ISBN must be 10 or 13 digits, not 17", and a hyphenated ISBN-10 was even checked as an ISBN-13.The hyphens and spaces are now removed before validating, so these give the same normalised ISBN-13 as the plain digits. Invalid lengths and check digits are still rejected. Added cases to
test_isbn_length.