Repository navigation
Preserve newlines when parsing S3 object keys - #430
Merged
Merged
Conversation
yezz123
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3Path rejects keys with a newline in a prefix. For a path ending with a slash followed by a newline, it silently drops the newline from key and reports a different last_key while retaining the original string value. AWS supports newline characters in object keys.
Compile the existing pattern with DOTALL and require a full match when extracting components. Regression tests cover direct construction and Pydantic validation with embedded newlines, multiple prefixes, CRLF, a final newline and a trailing slash.
Validation on Python 3.12.12: new tests fail on unchanged main (10 failed, 2 passed); all 37 S3 tests pass patched; the full suite passes (13615 tests). Changed-file Ruff lint/format and s3.py mypy pass.
No AWS requests were made. Other Python versions and the full repository typecheck were not run. The frozen lockfile omits pandas; pandas 3.0.6 and numpy 2.5.3 were installed separately for the full suite.